Skip to content

Return type name in resolveType #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

patrick91
Copy link
Member

Closes #1310

In this PR we updated GraphQL.js to 16 which removed the support for returning a GraphQLObjectType from resolveType.

I've changed the code to return the type name directly :)

The error was this:

{
  "errors": [
    {
      "message": "Support for returning GraphQLObjectType from resolveType was removed in graphql-js@16.0.0 please return type name instead.",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "hero"
      ]
    }
  ],
  "data": {
    "hero": null
  }
}

and is visible here: https://graphql.org/learn/queries/

@Urigo Urigo merged commit 35b796b into graphql:source Nov 16, 2022
@Urigo
Copy link
Contributor

Urigo commented Nov 16, 2022

thank you @patrick91 !

@patrick91 patrick91 deleted the fix/graphql-js-16 branch November 18, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of Interactive query is broken
2 participants